QONNX ingestion bug fixes #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghielme
force-pushed
the
qonnx-big-fixes
branch
from
1194737 to
e6273d6
Compare
jmitrevs
reviewed
Sep 20, 2024
| """ | ||
| rv = [] | ||
| for inp in node.input: | ||
| if inp == '': |
Owner
There was a problem hiding this comment.
When is this used? When are you asking for the input node of a node with no inputs?
Author
There was a problem hiding this comment.
It happens with Resize node, https://onnx.ai/onnx/operators/onnx__Resize.html
I agree it is not super clean but I didn't figure out another solution. The handling of RoI field should also be considered at QONNX level
jmitrevs
pushed a commit
that referenced
this pull request
Feb 12, 2025
Fix pytorch simple RNN for oneAPI; add initial state version for Quartus and oneAPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain a set of bug fix encountered during the ingestion of a UNet like model.
Type of change
Different kind of bug fixes.
Note: Please delete options that are not relevant.
Tests
Missing at the moment but they will be added in a second time.
Checklist
pre-commiton the files I edited or added.